Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup modular conversion w/ multiproc #36073

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

muellerzr
Copy link
Contributor

@muellerzr muellerzr commented Feb 6, 2025

What does this PR do?

During my last PR, I found that make fix-copies was taking a ton of time. Trying to make it a bit faster by using multiproc instead. Let me know what we think.

Times calling time python utils/check_modular_conversion.py --fix_and_overwrite:

  • Before (linear): 67s
  • After (multiproc): 6s

(Mileage may vary with multiproc, of course)

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker @Rocketknight1

@muellerzr muellerzr marked this pull request as draft February 6, 2025 17:34
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qubvel
Copy link
Member

qubvel commented Feb 6, 2025

I had the same thoughts just 15 minutes ago 😅 as far as I understand, files are topologically sorted, so the order of conversion matters, we should probably keep the dependency graph and apply multiprocessing level-by-level

@ArthurZucker
Copy link
Collaborator

Yep exactly!

@ArthurZucker
Copy link
Collaborator

Next level is to code it in rust :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants