[core] Fix import of randn_tensor
#751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shall we also update the required diffusers version |
|
LGTM. Let’s wait for tests to pass and merge. |
|
The documentation is not available anymore as the PR was closed or merged. |
|
Thanks everyone!
I think this is not strictly needed as that method always lived there since 0.18.0: https://github.com/huggingface/diffusers/blob/v0.18.0/src/diffusers/utils/torch_utils.py#L36 |
|
can we please do a release for this? |
|
Yes @neo we will have a release soon |
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes huggingface/autotrain-advanced#259
With huggingface/diffusers#4829 being merged it changed a bit the structure of diffusers lib. the method
randn_tensorwhich always lives insidediffusers.utils.torch_utilshas been removed fromdiffusers.utils' init. Therefore causes import issues for users that are using the latest diffusers or in the next release. This PR fixes thiscc @kashif @vwxyzjn