Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #142 return dist.mat even if it is invalid #165

Conversation

dsmith-unbc
Copy link
Collaborator

Minor changes to explore(), residency(), and migration() code to keep distance matrix when it is invalid but denote it with NA instead of an actual matrix of distances.

Once merged, this fixes issue #142

dsmith-unbc and others added 7 commits December 10, 2024 12:36
…igration, and residency analysis even if it is invalid. Also made sure distance matrix is retains if results are being saved.
…alysis output when invalid or missing (denoted as NA).
…alid' of github.com:dsmith-unbc/actel_dsmith into issue-hugomflavio#142-Return-dist.mat-even-if-it-is-invalid
Copy link
Owner

@hugomflavio hugomflavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I have only one question regarding the news line; have a look. I'd recommend bumping the dev version since we're adding a new news line. Added a few spaces.

dsmith-unbc and others added 5 commits December 10, 2024 15:48
addition of spaces

Co-authored-by: Hugo Flávio <[email protected]>
addition of a space

Co-authored-by: Hugo Flávio <[email protected]>
…alid' of github.com:dsmith-unbc/actel_dsmith into issue-hugomflavio#142-Return-dist.mat-even-if-it-is-invalid
Copy link
Owner

@hugomflavio hugomflavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff 👍

@hugomflavio
Copy link
Owner

Sorry, forgot to merge this earlier!

@hugomflavio hugomflavio merged commit 980edfe into hugomflavio:master Dec 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants