fix: update doh to new iso-kv ttl in seconds

hugomrdias · Feb 5, 2024 · 6023226 · 6023226
1 parent 6452696
commit 6023226
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/iso-web/src/doh/index.js b/packages/iso-web/src/doh/index.js
@@ -195,23 +195,23 @@ export async function resolve(query, type, options = {}) {
     const out = {
       error: new DohError(error, { data: result }),
     }
-    await cache.set([url], out, 3600) // caches errors for 1 hour
+    await cache.set([url], out, { ttl: 3600 }) // caches errors for 1 hour
     return out
   }
 
   if (result.Answer) {
     const data = result.Answer.map((a) => a.data.replaceAll(/["']+/g, ''))
     const ttl = Math.min(...result.Answer.map((a) => a.TTL))
     const out = { result: data }
-    await cache.set([url], out, ttl)
+    await cache.set([url], out, { ttl })
     return out
   }
 
   if (result.Authority) {
     const data = result.Authority.map((a) => a.data)
     const ttl = Math.min(...result.Authority.map((a) => a.TTL))
     const out = { result: data }
-    await cache.set([url], out, ttl)
+    await cache.set([url], out, { ttl })
     return out
   }
 

diff --git a/packages/iso-web/test/doh.test.js b/packages/iso-web/test/doh.test.js
@@ -111,7 +111,7 @@ test('should resolve from cache', async () => {
   }
 
   // second from cache
-  await cache.set([url], { result: [1] }, 1)
+  await cache.set([url], { result: [1] }, { ttl: 1 })
 
   const out1 = await resolve('google.com', 'A', {
     cache,