Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 buffer overflows in TIFF decoding #47

Merged
merged 5 commits into from
Apr 1, 2020
Merged

Fix 2 buffer overflows in TIFF decoding #47

merged 5 commits into from
Apr 1, 2020

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented Apr 1, 2020

No description provided.

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #47 into master will decrease coverage by 0.06%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   89.84%   89.77%   -0.07%     
==========================================
  Files         328      326       -2     
  Lines       40845    40842       -3     
==========================================
- Hits        36696    36666      -30     
- Misses       4149     4176      +27
Flag Coverage Δ
#AppVeyor 88.13% <ø> (-1.34%) ⬇️
#GHA_Docker 85.94% <40%> (-0.02%) ⬇️
#GHA_Ubuntu 88.03% <40%> (+0.03%) ⬆️
#GHA_Windows ?
#GHA_macOS 87.01% <40%> (-0.04%) ⬇️
#TravisCI 92.66% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/libImaging/TiffDecode.c 83.33% <40%> (-1.64%) ⬇️
Tests/test_imagefont_bitmap.py 91.3% <0%> (-8.7%) ⬇️
Tests/test_features.py 96.92% <0%> (-3.08%) ⬇️
src/PIL/ImageTk.py 73.59% <0%> (-2.41%) ⬇️
src/PIL/ImageCms.py 83.11% <0%> (-2.23%) ⬇️
src/PIL/features.py 95.78% <0%> (-2.11%) ⬇️
Tests/test_file_webp.py 98% <0%> (-2%) ⬇️
src/PIL/XpmImagePlugin.py 89.28% <0%> (-1.79%) ⬇️
src/PIL/ImageFont.py 94.71% <0%> (-1.45%) ⬇️
Tests/test_file_icns.py 98.75% <0%> (-1.25%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f9e19...2092801. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #47 into master will decrease coverage by 0.06%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   89.84%   89.77%   -0.07%     
==========================================
  Files         328      326       -2     
  Lines       40845    40842       -3     
==========================================
- Hits        36696    36666      -30     
- Misses       4149     4176      +27
Flag Coverage Δ
#AppVeyor 88.13% <ø> (-1.34%) ⬇️
#GHA_Docker 85.94% <40%> (-0.02%) ⬇️
#GHA_Ubuntu 88.03% <40%> (+0.03%) ⬆️
#GHA_Windows ?
#GHA_macOS 87.01% <40%> (-0.04%) ⬇️
#TravisCI 92.66% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/libImaging/TiffDecode.c 83.33% <40%> (-1.64%) ⬇️
Tests/test_imagefont_bitmap.py 91.3% <0%> (-8.7%) ⬇️
Tests/test_features.py 96.92% <0%> (-3.08%) ⬇️
src/PIL/ImageTk.py 73.59% <0%> (-2.41%) ⬇️
src/PIL/ImageCms.py 83.11% <0%> (-2.23%) ⬇️
src/PIL/features.py 95.78% <0%> (-2.11%) ⬇️
Tests/test_file_webp.py 98% <0%> (-2%) ⬇️
src/PIL/XpmImagePlugin.py 89.28% <0%> (-1.79%) ⬇️
src/PIL/ImageFont.py 94.71% <0%> (-1.45%) ⬇️
Tests/test_file_icns.py 98.75% <0%> (-1.25%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f9e19...2092801. Read the comment docs.

@hugovk hugovk merged commit 46f4a34 into master Apr 1, 2020
@hugovk hugovk deleted the fix_tiff branch April 1, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants