-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add filter for content_url and plugins_url #32
Comments
… url instead of constant values fixes humanmade#32
Thanks. This fixed an issue with some font icons on a theme not appearing on an alias. Possibly connected. I'm using the Simple Social Icons plugin (https://wordpress.org/plugins/simple-social-icons/), which seems to be relying on |
Spoke too soon. Adding those lines created this error in the php logs: [13-Apr-2015 16:01:50 UTC] PHP Warning: Missing argument 4 for Mercator\mangle_url() in .../wp-content/mu-plugins/mercator/mercator.php on line 302 |
Ah I finally found it. I've been searching all the issues as I assumed it had to already be here. I have resolved this issue in my fork, I'm going to send a push request with the fix now. I've tested it locally and it resolves the issues with content_url function which feeds the plugins_url function as well. |
Because
content_url()
andplugins_url()
are still based on some default constants (see link-template.php L#2798 and L#2830), we have to add yourmangle_url
filtert here also.I think this would be a nice place.
The text was updated successfully, but these errors were encountered: