Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filter for content_url and plugins_url #32

Open
carstingaxion opened this issue Jan 12, 2015 · 3 comments
Open

add filter for content_url and plugins_url #32

carstingaxion opened this issue Jan 12, 2015 · 3 comments

Comments

@carstingaxion
Copy link
Contributor

Because content_url() and plugins_url() are still based on some default constants (see link-template.php L#2798 and L#2830), we have to add your mangle_url filtert here also.

I think this would be a nice place.

carstingaxion added a commit to carstingaxion/Mercator that referenced this issue Jan 13, 2015
@mrjarbenne
Copy link

Thanks. This fixed an issue with some font icons on a theme not appearing on an alias.

Possibly connected. I'm using the Simple Social Icons plugin (https://wordpress.org/plugins/simple-social-icons/), which seems to be relying on plugin_dir_url for the CSS. When you navigate to the site using the domain set in the Siteurl everything works, but when visiting an alias the CSS is broken.

@mrjarbenne
Copy link

Spoke too soon. Adding those lines created this error in the php logs:

[13-Apr-2015 16:01:50 UTC] PHP Warning: Missing argument 4 for Mercator\mangle_url() in .../wp-content/mu-plugins/mercator/mercator.php on line 302

@scarstens
Copy link

Ah I finally found it. I've been searching all the issues as I assumed it had to already be here. I have resolved this issue in my fork, I'm going to send a push request with the fix now. I've tested it locally and it resolves the issues with content_url function which feeds the plugins_url function as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants