Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privacy API docs #48

Merged
merged 3 commits into from
Aug 3, 2019
Merged

Add Privacy API docs #48

merged 3 commits into from
Aug 3, 2019

Conversation

roborourke
Copy link
Contributor

Fixes #47

Copy link
Member

@rmccue rmccue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits here, all looks good otherwise!

docs/privacy-api.md Outdated Show resolved Hide resolved
docs/privacy-api.md Outdated Show resolved Hide resolved
docs/privacy-api.md Outdated Show resolved Hide resolved
// If you define your own group, the first exporter to
// include a label will be used as the group label in the
// final exported report.
$group_label = __( 'Form Responses' );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add text domains?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of example code it's probably ok but can do

docs/privacy-api.md Outdated Show resolved Hide resolved
docs/privacy-api.md Outdated Show resolved Hide resolved
docs/privacy-api.md Outdated Show resolved Hide resolved
docs/privacy-api.md Outdated Show resolved Hide resolved
docs/privacy-api.md Outdated Show resolved Hide resolved
docs/privacy-api.md Outdated Show resolved Hide resolved
Copy link
Member

@joehoyle joehoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After @rmccue's feedback, looks great

docs/privacy-api.md Outdated Show resolved Hide resolved
docs/privacy-api.md Outdated Show resolved Hide resolved
@roborourke
Copy link
Contributor Author

@joehoyle done :)

@joehoyle joehoyle merged commit b9fa23d into master Aug 3, 2019
@joehoyle joehoyle deleted the privacy-api-docs branch August 3, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs on CMS privacy page feature
3 participants