Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugin url paths #7

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fix plugin url paths #7

merged 1 commit into from
Mar 27, 2019

Conversation

roborourke
Copy link
Contributor

This ensures the path has a trailing slash before it's appended to the plugin directory URL. Issue noticed with AMP plugin.

hm-linter[bot]
hm-linter bot reviewed Mar 26, 2019
View reviewed changes
Copy link

@hm-linter hm-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (3 errors, 13 warnings).

16 notices occurred in your codebase, but none on files/lines included in this PR.

@roborourke roborourke requested a review from joehoyle March 26, 2019 17:18
@joehoyle joehoyle merged commit 6b4e670 into master Mar 27, 2019
@joehoyle joehoyle deleted the fix-plugin-paths branch March 27, 2019 03:01
@roborourke roborourke mentioned this pull request Apr 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hm-linter hm-linter[bot] hm-linter[bot] left review comments

@joehoyle joehoyle joehoyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roborourke @joehoyle