-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix features script check to skip dev packages
- Loading branch information
1 parent
eb8ba52
commit 16eb026
Showing
2 changed files
with
5 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,6 +77,10 @@ def list_expected_propagated_features(feature, _package, deps) | |
default_enabled = dep[:dependency]['uses_default_features'] | ||
next false if default_enabled && package_feature_enabled_by(dep[:package], 'default', feature) | ||
|
||
# If the package is used as dev dependency - skip it, as we don't need to specify | ||
# the feature. | ||
next false if dep[:dependency]['kind'] == 'dev' | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
dmitrylavrenov
Author
Contributor
|
||
|
||
true | ||
end | ||
deps_with_feature.map do |name, _dep| | ||
|
But we do usually need to set the features though.