Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused pallet-base-fee and pallet-dynamic-fee deps #737

Merged
merged 3 commits into from
Aug 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions crates/humanode-peer/src/cli/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,6 @@ pub trait CliConfigurationExt: SubstrateCliConfigurationProvider {
None
}

/// Provide the evm params, if available.
fn evm_params(&self) -> Option<&params::EvmParams> {
None
}

/// Provide the Ethereum RPC params.
fn ethereum_rpc_params(&self) -> Option<&params::EthereumRpcParams> {
None
Expand Down
8 changes: 0 additions & 8 deletions crates/humanode-peer/src/cli/params.rs
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,6 @@ pub struct BioauthFlowParams {
pub robonode_url: Option<String>,
}

/// Shared CLI parameters used to configure EVM.
#[derive(Debug, clap::Parser, Clone)]
pub struct EvmParams {
/// The dynamic-fee pallet target gas price set by block author.
#[arg(long, default_value = "1")]
pub target_gas_price: u64,
}

/// Shared CLI parameters used to configure Ethereum RPC.
#[derive(Debug, clap::Parser, Clone)]
pub struct EthereumRpcParams {
Expand Down
8 changes: 0 additions & 8 deletions crates/humanode-peer/src/cli/run_cmd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ pub struct RunCmd {
#[command(flatten)]
pub bioauth_flow_params: params::BioauthFlowParams,

#[allow(missing_docs, clippy::missing_docs_in_private_items)]
#[command(flatten)]
pub evm_params: params::EvmParams,

#[allow(missing_docs, clippy::missing_docs_in_private_items)]
#[command(flatten)]
pub ethereum_rpc_params: params::EthereumRpcParams,
Expand All @@ -41,10 +37,6 @@ impl CliConfigurationExt for RunCmd {
Some(&self.bioauth_flow_params)
}

fn evm_params(&self) -> Option<&params::EvmParams> {
Some(&self.evm_params)
}

fn ethereum_rpc_params(&self) -> Option<&params::EthereumRpcParams> {
Some(&self.ethereum_rpc_params)
}
Expand Down
6 changes: 0 additions & 6 deletions crates/humanode-runtime/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ libsecp256k1 = { version = "0.7", default-features = false }
pallet-authorship = { default-features = false, git = "https://github.com/humanode-network/substrate", branch = "locked/polkadot-v0.9.38" }
pallet-babe = { default-features = false, git = "https://github.com/humanode-network/substrate", branch = "locked/polkadot-v0.9.38" }
pallet-balances = { default-features = false, git = "https://github.com/humanode-network/substrate", branch = "locked/polkadot-v0.9.38" }
pallet-base-fee = { default-features = false, git = "https://github.com/humanode-network/frontier", branch = "locked/polkadot-v0.9.38" }
pallet-dynamic-fee = { default-features = false, git = "https://github.com/humanode-network/frontier", branch = "locked/polkadot-v0.9.38" }
pallet-ethereum = { default-features = false, git = "https://github.com/humanode-network/frontier", branch = "locked/polkadot-v0.9.38" }
pallet-evm = { default-features = false, git = "https://github.com/humanode-network/frontier", branch = "locked/polkadot-v0.9.38" }
pallet-evm-balances = { default-features = false, git = "https://github.com/humanode-network/frontier", branch = "locked/polkadot-v0.9.38" }
Expand Down Expand Up @@ -161,13 +159,11 @@ std = [
"pallet-babe/std",
"pallet-balanced-currency-swap-bridges-initializer/std",
"pallet-balances/std",
"pallet-base-fee/std",
"pallet-bioauth/std",
"pallet-bootnodes/std",
"pallet-chain-properties/std",
"pallet-chain-start-moment/std",
"pallet-currency-swap/std",
"pallet-dynamic-fee/std",
"pallet-ethereum-chain-id/std",
"pallet-ethereum/std",
"pallet-evm-accounts-mapping/std",
Expand Down Expand Up @@ -230,13 +226,11 @@ try-runtime = [
"pallet-babe/try-runtime",
"pallet-balanced-currency-swap-bridges-initializer/try-runtime",
"pallet-balances/try-runtime",
"pallet-base-fee/try-runtime",
"pallet-bioauth/try-runtime",
"pallet-bootnodes/try-runtime",
"pallet-chain-properties/try-runtime",
"pallet-chain-start-moment/try-runtime",
"pallet-currency-swap/try-runtime",
"pallet-dynamic-fee/try-runtime",
"pallet-ethereum-chain-id/try-runtime",
"pallet-ethereum/try-runtime",
"pallet-evm-accounts-mapping/try-runtime",
Expand Down
9 changes: 0 additions & 9 deletions utils/checks/snapshots/features.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -931,9 +931,6 @@
features:
- default
- std
- name: fp-dynamic-fee 1.0.0
features:
- std
- name: fp-ethereum 1.0.0-dev
features:
- default
Expand Down Expand Up @@ -1979,9 +1976,6 @@
features:
- default
- std
- name: pallet-base-fee 1.0.0
features:
- std
- name: pallet-bioauth 0.1.0
features:
- default
Expand All @@ -2006,9 +2000,6 @@
features:
- default
- std
- name: pallet-dynamic-fee 4.0.0-dev
features:
- std
- name: pallet-ethereum 4.0.0-dev
features:
- std
Expand Down
5 changes: 0 additions & 5 deletions utils/e2e-tests/bash/fixtures/help.stdout.txt
Original file line number Diff line number Diff line change
Expand Up @@ -630,11 +630,6 @@ Options:
--robonode-url <ROBONODE_URL>
The URL of robonode to authenticate with

--target-gas-price <TARGET_GAS_PRICE>
The dynamic-fee pallet target gas price set by block author

[default: 1]

--max-past-logs <MAX_PAST_LOGS>
Maximum number of logs to keep from the latest block; it is not possible to query logs older than this amount from the latest block in the past

Expand Down