do not validate files and ignores twice

src/base-schema.js

@@ -7,43 +7,13 @@
 // Helpers
 //------------------------------------------------------------------------------
 
-/**
- * Assets that a given value is an array.
- * @param {*} value The value to check.
- * @returns {void}
- * @throws {TypeError} When the value is not an array. 
- */
-function assertIsArray(value) {
-	if (!Array.isArray(value)) {
-		throw new TypeError('Expected value to be an array.');
-	}
-}
-
-/**
- * Assets that a given value is an array containing only strings and functions.
- * @param {*} value The value to check.
- * @returns {void}
- * @throws {TypeError} When the value is not an array of strings and functions.
- */
-function assertIsArrayOfStringsAndFunctions(value, name) {
-	assertIsArray(value, name);
-
-	if (value.some(item => typeof item !== 'string' && typeof item !== 'function')) {
-		throw new TypeError('Expected array to only contain strings and functions.');
-	}
-}
-
-/**
- * Assets that a given value is a non-empty array.
- * @param {*} value The value to check.
- * @returns {void}
- * @throws {TypeError} When the value is not an array or an empty array.
- */
-function assertIsNonEmptyArray(value) {
-	if (!Array.isArray(value) || value.length === 0) {
-		throw new TypeError('Expected value to be a non-empty array.');
-	}
-}
+const NOOP_STRATEGY = {
+	required: false,
+	merge() {
+		return undefined;
+	},
+	validate() { }
+};
 
 //------------------------------------------------------------------------------
 // Exports
@@ -65,32 +35,6 @@ export const baseSchema = Object.freeze({
 			}
 		}
 	},
-	files: {
-		required: false,
-		merge() {
-			return undefined;
-		},
-		validate(value) {
-
-			// first check if it's an array
-			assertIsNonEmptyArray(value);
-
-			// then check each member
-			value.forEach(item => {
-				if (Array.isArray(item)) {
-					assertIsArrayOfStringsAndFunctions(item);
-				} else if (typeof item !== 'string' && typeof item !== 'function') {
-					throw new TypeError('Items must be a string, a function, or an array of strings and functions.');
-				}
-			});
-
-		}
-	},
-	ignores: {
-		required: false,
-		merge() {
-			return undefined;
-		},
-		validate: assertIsArrayOfStringsAndFunctions
-	}
+	files: NOOP_STRATEGY,
+	ignores: NOOP_STRATEGY
 });

src/config-array.js

@@ -13,6 +13,7 @@ import createDebug from 'debug';
 
 import { ObjectSchema } from '@humanwhocodes/object-schema';
 import { baseSchema } from './base-schema.js';
+import { filesAndIgnoresSchema } from './files-and-ignores-schema.js';
 
 //------------------------------------------------------------------------------
 // Helpers
@@ -30,7 +31,7 @@ const MINIMATCH_OPTIONS = {
 
 const CONFIG_TYPES = new Set(['array', 'function']);
 
-const BASE_SCHEMA = new ObjectSchema(baseSchema);
+const FILES_AND_IGNORES_SCHEMA = new ObjectSchema(filesAndIgnoresSchema);
 
 /**
  * Shorthand for checking if a value is a string.
@@ -55,7 +56,7 @@ function assertValidFilesAndIgnores({ files, ignores }) {
 	if (ignores !== undefined) {
 		validateConfig.ignores = ignores;
 	}
-	BASE_SCHEMA.validate(validateConfig);
+	FILES_AND_IGNORES_SCHEMA.validate(validateConfig);
 }
 
 /**

src/files-and-ignores-schema.js

@@ -0,0 +1,85 @@
+/**
+ * @fileoverview ConfigSchema
+ * @author Nicholas C. Zakas
+ */
+
+//------------------------------------------------------------------------------
+// Helpers
+//------------------------------------------------------------------------------
+
+/**
+ * Asserts that a given value is an array.
+ * @param {*} value The value to check.
+ * @returns {void}
+ * @throws {TypeError} When the value is not an array.
+ */
+function assertIsArray(value) {
+	if (!Array.isArray(value)) {
+		throw new TypeError('Expected value to be an array.');
+	}
+}
+
+/**
+ * Asserts that a given value is an array containing only strings and functions.
+ * @param {*} value The value to check.
+ * @returns {void}
+ * @throws {TypeError} When the value is not an array of strings and functions.
+ */
+function assertIsArrayOfStringsAndFunctions(value, name) {
+	assertIsArray(value, name);
+
+	if (value.some(item => typeof item !== 'string' && typeof item !== 'function')) {
+		throw new TypeError('Expected array to only contain strings and functions.');
+	}
+}
+
+/**
+ * Asserts that a given value is a non-empty array.
+ * @param {*} value The value to check.
+ * @returns {void}
+ * @throws {TypeError} When the value is not an array or an empty array.
+ */
+function assertIsNonEmptyArray(value) {
+	if (!Array.isArray(value) || value.length === 0) {
+		throw new TypeError('Expected value to be a non-empty array.');
+	}
+}
+
+//------------------------------------------------------------------------------
+// Exports
+//------------------------------------------------------------------------------
+
+/**
+ * The schema for `files` and `ignores` that every ConfigArray uses.
+ * @type Object
+ */
+export const filesAndIgnoresSchema = Object.freeze({
+	files: {
+		required: false,
+		merge() {
+			return undefined;
+		},
+		validate(value) {
+
+			// first check if it's an array
+			assertIsNonEmptyArray(value);
+
+			// then check each member
+			value.forEach(item => {
+				if (Array.isArray(item)) {
+					assertIsArrayOfStringsAndFunctions(item);
+				} else if (typeof item !== 'string' && typeof item !== 'function') {
+					throw new TypeError('Items must be a string, a function, or an array of strings and functions.');
+				}
+			});
+
+		}
+	},
+	ignores: {
+		required: false,
+		merge() {
+			return undefined;
+		},
+		validate: assertIsArrayOfStringsAndFunctions
+	}
+});

tests/config-array.test.js

@@ -381,6 +381,23 @@ describe('ConfigArray', () => {
 				.throw('Key "ignores": Expected array to only contain strings and functions.');
 
 		});
+
+		it('should throw an error when name is not a string', async () => {
+			configs = new ConfigArray([
+				{
+					files: ['**'],
+					name: true
+				}
+			], { basePath });
+			await configs.normalize();
+
+			expect(() => {
+				configs.getConfig(path.resolve(basePath, 'foo.js'));
+			})
+				.to
+				.throw('Key "name": Property must be a string.');
+
+		});
 	});
 
 	describe('ConfigArray members', () => {