New Registration Screen #53
Conversation
…to new-registration-screen
|
@BilalBudhani @joshmadewell it'd be great if you guys can review this. |
| import { View, Text, TouchableOpacity, ScrollView, Dimensions } from 'react-native'; | ||
| import { intro1, intro2, intro3, intro4 } from 'kitsu/assets/img/onboarding/'; | ||
| >>>>>>> ac7ac011c40b7d0948eef59ca59ff6b91fec105f |
There was a problem hiding this comment.
@edencakir you missed resolving a conflict here.
There was a problem hiding this comment.
Ah thanks for the heads up. I'm not sure how I missed that.
|
@edencakir when I try to sign in with my username & password; nothing happens after pressing sign in button, I just see loading indicator on the button forever. Please look into this. |
|
@BilalBudhani This PR has nothing to do with Login or Signup screens (except facebook login). This is just a landing screen after onboarding. So for that, we should better look at the login screen. |
|
@edencakir Okay. I think #66 branch by @joshmadewell fixed that issue. |
|
@BilalBudhani Great, let me go through this PR before merging. |
…r/kitsu-mobile into new-registration-screen
|
@BilalBudhani Done, should be ready to merge |
About improving scroll animation performance; if these get merged I guess these animations will be way better. Until then we can also consider using gifs or a video:
facebook/react-native#15609
facebook/react-native#15610
Android inverted flatlist issue: facebook/react-native#14560