-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure prettier for this project. #24
Conversation
update the contribution file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that pushing an empty config file will let the IDE know that we are using prettier
, but some content should be in the file. Maybe options such as tabWidth
, since I see its equivalent in settings.json
. Also, I think you could safely add singleQuote
and semi
options to prettierrc.json
. It should not break the code.
See more about |
Thanks for the review @SerpentBytes |
It seems like what you need is also being added in #22. Could you collaborate with @sfrunza13 so that when we merge #22 and #24, there's only a single |
Just add the |
@anshul137 The .prettierrc.js file is a config file for prettier that we can commit to ensure it behaves in the way we want it to for anyone who decides to work on the project. Feel free to take the one I have written in my PR and add to yours. I am pretty sure .json also works as a format for the prettierrc file, however I would not commit the .vscode folder as it has to do with the editors settings and not the project I believe. |
@anshul137 could you please make the requested adjustments? Also, please resolve any merge conflicts. |
@SerpentBytes yes i will work on it and fix the conflict |
@SerpentBytes can you please check and let me know if it need any changes i have resolved the conflict in merge as well. |
@anshul137 LGTM ✅ |
@SerpentBytes Can you merge pull request ? |
Closes #23
Description
Added the Prettier into this project
.vscode
folderextensions.json
file added Prettier as the recommendationsettings.json
added configration.npm run format
.npm run format:check
.prettierignore
.prettierrc.json
CONTRIBUTING.md
on how to use Prettier via command line