StatusBar appareance when moving to another UIViewController

[RemiRodrigues]

Describe the bug
Hello, I have a problem with the statusBar appearance. Screenshots below describe the bug.

To Reproduce
Steps to reproduce the behavior:

1. Display a UIViewController with a white background, and dark statusBar
2. Display, as popover, a UIViewController with a black background, and a light statusBar
3. Display a StatusBar's EntryView with an orange background
4. Before the EntryView dismissed, close the popover, and return back to the white UIViewController
5. When the statusBar disappear, the statusBar become "light" on the white UIViewController

Expected behavior
Keep statusBar appearence.

Screenshots
First UIViewController with white background :

Second UIViewController with dark background :

Display StatusBar's EntryView on dark UIViewController :

Close dark UIViewController :

When the StatusBar's EntryView is dismissed, the statusBar is light :

Configuration :

• Device: iPhone 6
• iOS Version: 11.4
• Xcode Version 9.4.1
• Dependency Manager : CocoaPods
• SwiftEntryKit Release : 0.6.0

Additional context
I can solve the bug removnig this method on EKRootViewController class :

override public func viewWillDisappear(_ animated: Bool) {
        super.viewWillDisappear(animated)
        statusBar = previousStatusBar
}

But this seems really a bad idea...

Thanks for your help, this pod is really helpful 👍

[huri000]

Hi! Thanks for opening the issue. Unfortunately I won’t be able to investigate this until Sep 27 since I’m not near my Mac. Please make any adjustments / workarounds as you see fit inside a fork. I’ll make sure to look into it when I’m available again. Cheers!

[huri000]

Thinking it through, the fix should specifically refer to a situation where the entry is displayed above the status bar. In that case - the status bar appearence should not be manipulated - since it’s already placed below the entry.

[huri000]

@RemiRodrigues - Intuitively, It feels like a bug. Yet, I couldn't help but think that a fix for it is an enhancement as well. I mean, to truly handle that kind of issue SwiftEntryKit should listen to the status bar updates, which as far as I know, is not fully possible. The other option is to add an additional status bar style which implied SwiftEntryKit that it should ignore the status bar entirely in some cases. That can be tricky when chaining multiple entries with different values of status bars.
But I guess it's O.K if you know what you're doing.
So... I've added that status in a bugfix branch. I'll keep you updated when it's merged.
Please, let me know your thoughts.

[RemiRodrigues]

@huri000 thanks for your answer !

I think your second option, an additional status bar style, can be a light weight solution.

[huri000]

Hi @RemiRodrigues! Apologies for the delay. A fix is available on 0.8.8. Please let me know if that works for you. 🎉
See the CHANGELOG for status bar info.