Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for translating_date and comment actor check in the publish… #115

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

mudongliang
Copy link
Member

… operation

@mudongliang mudongliang requested a review from inscripoem July 17, 2024 14:45
Copy link
Member

@inscripoem inscripoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there is not a translating_date item in most source markdowns' metadata whose status is translating. Is this a new item? BTW, the corresponding comments may also needed to be updated regarding this function.

Besides, I think it would be better to add all other date order checks if there's already one cheking collected date and translating date in this pr. Apparently this will cost more duplicated lines extracting date items (like collected_date in this case, which is why I want to refactor the logic flow.

Of course the code itself is fine and ready to be merged. Paragraphs above are just for discussion.

@mudongliang
Copy link
Member Author

It seems that there is not a translating_date item in most source markdowns' metadata whose status is translating. Is this a new item? BTW, the corresponding comments may also needed to be updated regarding this function.

Yes, for now there is no such a field. I would like to add this field in the frontmatter. And then keep this translating_date and translated_date, we can collect how many on average days usually one translator need.

Besides, I think it would be better to add all other date order checks if there's already one cheking collected date and translating date in this pr. Apparently this will cost more duplicated lines extracting date items (like collected_date in this case, which is why I want to refactor the logic flow.

I think the most functionability I would like to add is to identify if this PR changes from one status to another status. If we understand this point, it is really to check the integrity of the metadata. And this can avoid the FP of minor fixes after the proofreading or publishing.

Of course the code itself is fine and ready to be merged. Paragraphs above are just for discussion.

@mudongliang mudongliang merged commit db60237 into master Jul 18, 2024
2 checks passed
@mudongliang mudongliang deleted the fix_github_action branch July 23, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants