Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to windows crate #155

Closed
thewh1teagle opened this issue Dec 26, 2023 · 1 comment · Fixed by #159
Closed

Consider switching to windows crate #155

thewh1teagle opened this issue Dec 26, 2023 · 1 comment · Fixed by #159
Labels
dependencies Pull requests that update a dependency file waiting Waiting for an action outside the repo

Comments

@thewh1teagle
Copy link

thewh1teagle commented Dec 26, 2023

I found that you use winapi-rs crate for windows related functions which is not updated (2 years already).
Microsoft released official windows crate for rust for winapi.

I used it in my project for similar things (dpapi) in this project:

@brotskydotcom brotskydotcom added the waiting Waiting for an action outside the repo label Dec 26, 2023
@brotskydotcom
Copy link
Collaborator

Thanks for this suggestion.

While I agree the Microsoft windows crate looks promising, it hasn't reached a level of stability that makes me want to do the porting work. The fact that the winapi-rs crate has not been updated in 2 years is, I believe, simply an artifact of its robustness and the stability of the windows APIs it wraps.

At this point, I think I will hold off until one of the following happens:

  • Microsoft releases v1.0 of the windows crate (or otherwise warrants its stability).
  • Someone reports a bug in this crate that stems from use of winapi-rs and is fixed in the Microsoft windows crate.
  • Someone reports an incompatibility between winapi-rs and other crates that doesn't repro with the Microsoft windows crate.

I am going to leave this bug open pending one of these events. If you are highly motivated to see this crate use the Microsoft windows crate, feel free to submit a PR with the port, and I'll take a look.

@brotskydotcom brotskydotcom added the dependencies Pull requests that update a dependency file label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file waiting Waiting for an action outside the repo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants