Migrate to windows-sys from winapi #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brotskydotcom
approved these changes
Jan 1, 2024
There was a problem hiding this comment.
Wow! Such a simple change; I had no idea. Thanks so much for doing this! As someone familiar with this platform and this API, it was probably easy for you, and it saves me an enormous learning curve which I am glad to avoid! :)
By all means feel free to do any more code cleanup you feel is warranted, but this change looks terrific to me. Once I have time to do a little hands-on testing to supplement the CI tests, I will release this.
| @@ -1,6 +1,6 @@ | |||
| /*! | |||
|
|
|||
| # Windows Crendential Manager credential store | |||
| # Windows Credential Manager credential store | |||
There was a problem hiding this comment.
Hahaha thanks for catching this typo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces winapi with windows-sys. Most of the migration was just replacing imports. All of the tests pass.
Resolves #155