Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In reply links are opened internally #14

Closed
pherjung opened this issue Nov 19, 2023 · 2 comments
Closed

In reply links are opened internally #14

pherjung opened this issue Nov 19, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@pherjung
Copy link
Contributor

Even opening link is disabled, it's still possible to click on specific link like:

<a class="link" href="Matrix URL">In reply to</a>
@pherjung
Copy link
Contributor Author

If hydrogen is opened again with the D-Bus stuff, it should be a workaround to this bug

@nephros nephros added the bug Something isn't working label Nov 20, 2023
@pherjung
Copy link
Contributor Author

pherjung commented Nov 20, 2023 •
edited
Loading

It's actually a bug on hydrogen side. Adding target: "_blank".
src/platform/web/ui/session/room/timeline/ReplyPreviewView.js. It should be:

+                t.a({ className: "link", target: "_blank", href: vm.permaLink }, "This is second test"),
+                t.a({ className: "pill", target: "_blank", href: vm.senderProfileLink }, [

pherjung pushed a commit to hydrogen-sailfishos/hydrogen-web that referenced this issue Nov 20, 2023
Set a _blank target to the In Reply links. Fix hydrogen-sailfishos/ha…
f0cfa66 
…rbour-hydrogen#14
b100dian pushed a commit to hydrogen-sailfishos/hydrogen-web that referenced this issue Dec 31, 2023
@b100dian
Set a _blank target to the In Reply links. Fix hydrogen-sailfishos/ha…
7c9c613 
…rbour-hydrogen#14
b100dian pushed a commit to hydrogen-sailfishos/hydrogen-web that referenced this issue Aug 25, 2024
@b100dian
Set a _blank target to the In Reply links. Fix hydrogen-sailfishos/ha…
f21867d 
…rbour-hydrogen#14

Signed-off-by: Vlad G. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nephros @pherjung