Feature/fundamentals

[kaessert]

Summary of Changes

This PR will add three fundamental-data endpoints

@hydrosquall

Checklist

• Code follows the style guidelines of this project
• Added tests for new functionality
• Update HISTORY.rst with an entry summarizing your change
• Tag a project maintainer

[codecov]

Codecov Report

Merging #581 (a2cfbc7) into master (820dfa0) will increase coverage by 0.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
+ Coverage   94.73%   95.29%   +0.55%     
==========================================
  Files           5        5              
  Lines         228      255      +27     
==========================================
+ Hits          216      243      +27     
  Misses         12       12              

Impacted Files	Coverage Δ
tiingo/api.py	95.00% <100.00%> (+0.69%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 820dfa0...a2cfbc7. Read the comment docs.

[hydrosquall]

@atarax thank you for this! This looks great, I appreciate the detail on the tests + docstrings.

2 questions before merging this:

1. Would you like to be added to the Contributors.rst?
2. Would you be interested in adding a section to the README.rst showing people basic usage of these new methods you've added? If not , we can add an issue for someone else to add examples.

[kaessert]

@atarax thank you for this! This looks great, I appreciate the detail on the tests + docstrings.

2 questions before merging this:

1. Would you like to be added to the Contributors.rst?
2. Would you be interested in adding a section to the README.rst showing people basic usage of these new methods you've added? If not , we can add an issue for someone else to add examples.

1. Of course, happy to be part of the community :)
2. I added examples to README.rst

[hydrosquall]

@atarax This looks great, thanks for adding the examples to the Readme! I don't see your edits on Contributors.rst, but if you include how you'd like your name / email to be included, I can add that to the release notes when this gets published to PyPi.

[hydrosquall]

One small doc change and this will be good to go.

[hydrosquall]

Can we edit this the startdate month/date for startDate are 0 padded like in the earlier example? Not sure if the API will handle the different number of digits correctly, so probably good to err on the safe side.

[kaessert]

It actually can, but i changed it for consistency ;)

[kaessert]

Contributors.rst

i don't see a file with that name? oO

[hydrosquall]

Apologies @atarax, too much context switching between projects lately: here it is :) https://github.com/hydrosquall/tiingo-python/blob/master/AUTHORS.rst

…

On Wed, Feb 10, 2021 at 5:18 AM atarax ***@***.***> wrote: Contributors.rst i don't see a file with that name? oO — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#581 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACE2MMYEW23UYSCEBDHGXEDS6JMP7ANCNFSM4XGNC6FQ> .

[kaessert]

Apologies @atarax, too much context switching between projects lately: here it is :) https://github.com/hydrosquall/tiingo-python/blob/master/AUTHORS.rst
…
On Wed, Feb 10, 2021 at 5:18 AM atarax @.***> wrote: Contributors.rst i don't see a file with that name? oO — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#581 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACE2MMYEW23UYSCEBDHGXEDS6JMP7ANCNFSM4XGNC6FQ .

no worries, i know that kind of issues :)

[hydrosquall]

Thanks for doing this with clean git history too! Awesome work @atarax !

[kaessert]

Thanks for doing this with clean git history too! Awesome work @atarax !

You're welcome! :)