Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

drop sonar project form widget if project deleted #9

Merged

Conversation

alzafacon
Copy link
Contributor

Affects: all versions.


imagine:

  1. code quality widget is configured with sonar project named "quuz-bar"
  2. sonar project "quux-bar" is deleted from sonar

The user will see a warning that the says NOT FOUND on the white status bubble. This is not very helpful since the user does not know what was NOT FOUND.

  1. user recreates sonar project "quux-bar"
  2. AAAAHHHH!!! now there are duplicates in the database and mongo will start to through exceptions

This PR will remove the deleted sonar project from any widgets that previously had it configured. Thus preventing user confusion about what was NOT FOUND and database duplicates.

@rvema rvema added the bug Something isn't working label Nov 5, 2019
@Courtneyp123
Copy link
Contributor

@fidelcoria-aa "This branch is out-of-date with the base branch" - could you update please?

Copy link
Contributor

@rvema rvema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rvema rvema merged commit 846d597 into hygieia:master Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants