-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor java to kotlin, add showInAppMessageAndroid #365
Conversation
Codecov Report
@@ Coverage Diff @@
## main #365 +/- ##
==========================================
- Coverage 45.74% 42.18% -3.57%
==========================================
Files 3 4 +1
Lines 435 467 +32
==========================================
- Hits 199 197 -2
- Misses 236 270 +34
Continue to review full report at Codecov.
|
This PR seems to fix Issue #363 . Got no errors testing. |
Thanks for reviewing this. Since these are big changes I hope more people to spend time on this |
I use this Version since one week in production without any issues! The next commits are smaller :) |
I have reviewed the changes this week, and they are looking good! Just waiting for the merge to launch it to production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not actually reviewed this yet.
However, there are people who want this PR
to be merged so I'll give a try.
Hope it is safe.
Thanks again for the great work 🙏
-Refactor java to kotlin
-Improve android implementation
-Update Billing library to 4.1.0
-Add support for in app messages on android (Play Store)
Please turn codecov off for this PR