Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed consumable product purchase on Android #420

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

33-Elephants
Copy link
Contributor

For consumable items field "subscriptionOfferDetails" is always null therefore null pointer exception is always thrown in this method

@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #420 (fe38344) into main (33b69ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   47.69%   47.69%           
=======================================
  Files           4        4           
  Lines         478      478           
=======================================
  Hits          228      228           
  Misses        250      250           

see 1 file with indirect coverage changes

@copilot-wmt
Copy link

@hyochan Can you please check this? If you can merge this it would be grateful. currently In-App consumable product flow is broken on the android side.

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry for the late review. I've not tested this yet but I feel like there are others who've tested the PR.

I'll merge this is ship it! Thank you.

@hyochan hyochan added android android related issue bugfix labels Jun 22, 2023
@hyochan hyochan merged commit dafaa92 into hyochan:main Jun 22, 2023
@hyochan hyochan mentioned this pull request Jun 22, 2023
JoyHong pushed a commit to JoyHong/flutter_inapp_purchase that referenced this pull request Jul 6, 2023
For consumable items field "subscriptionOfferDetails" is always null
therefore null pointer exception is always thrown in this method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android android related issue bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants