Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Make Text Message Selectable #378

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

0916dhkim
Copy link
Collaborator

Specify project

react-native

Description

Make texts in message bubbles selectable by users.

Related Issues

There is a known issue where <Text> inside <FlatList> cannot be selectable.
It can be resolved by adding removeClippedSubviews={false} prop to <FlatList>.
facebook/react-native#26264

Tests

N/A

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@0916dhkim 0916dhkim added the 🍗 enhancement New feature or request label Apr 27, 2021
@0916dhkim 0916dhkim requested a review from hyochan April 27, 2021 02:29
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #378 (eb708a8) into master (b0fa348) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   76.76%   76.76%           
=======================================
  Files          62       62           
  Lines         964      964           
  Branches       95       95           
=======================================
  Hits          740      740           
  Misses        187      187           
  Partials       37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0fa348...eb708a8. Read the comment docs.

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@hyochan hyochan merged commit c1f72c9 into hyochan:master Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants