Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native 0.59.10 version #701

Closed
LukePenkava opened this issue Sep 6, 2019 · 9 comments
Closed

React Native 0.59.10 version #701

LukePenkava opened this issue Sep 6, 2019 · 9 comments
Labels
📖 documentation Improvements or additions to documentation

Comments

@LukePenkava
Copy link

Hi,

is it possible to update the docs with what version of react-native-iap is suitable for react native versions before 0.60 ? I have to stay for production reasons on 0.59.10 and would like to use iap module, but i am not sure which version is the right to use. Perhaps i missed some specification on that, but i could not find it.

I am guessing that i should use 3.0, since 3.1 requires migration to AndroidX ( which i cant do right now ). Let me please know if that is the case and as i mentioned, i think it could be useful for people to know which version to use for what RN version, at least pre 0.60.

Thanks
Luke

hyochan added a commit that referenced this issue Sep 7, 2019
@hyochan hyochan mentioned this issue Sep 7, 2019
hyochan added a commit that referenced this issue Sep 7, 2019
@hyochan hyochan added the 📖 documentation Improvements or additions to documentation label Sep 7, 2019
@hyochan
Copy link
Owner

hyochan commented Sep 7, 2019

Work done in #701 and [email protected].

hyochan added a commit that referenced this issue Sep 7, 2019
Release
- Fixes for #701 
   * Update installation doc to support all `RN` version to use `react-native-iap`.
   * Update `build.gradle` to make the updated `readme` work.
- Fixed more typings followed by #696.
@hyochan hyochan closed this as completed Sep 7, 2019
@LukePenkava
Copy link
Author

@hyochan Thank you. The documentation is now much more clear.

@kesepara
Copy link

@LukePenkava did you manage to find any solution?

@LukePenkava
Copy link
Author

@kesepara I am not sure what is specifically your issue, but i just followed the docs for <0.60. I am on iap version 3.4.6 with RN version 0.59.10. Also i am using pods for ios and did manual installation for Android. Everything works fine now.

@kesepara
Copy link

@LukePenkava I am on RN version 0.56.1 and also tried iap version 3.4.6, still get the same error which is "RNIapModule.java:5: error: package androidx.annotation does not exist". How did you manage to use this package without androidx?

@LukePenkava
Copy link
Author

@kesepara I dont know how you fix that error, if you get it. When i had androidx issue i rolled back to git version of the project without iap and installed it again with the new instructions in the docs. I suggest trying brand new RN 0.56.1 project and install it there based on the docs. If that does not work, try to start new RN project with 0.59.10 and see if that works. That should give you idea if that is something on your side or has something to do with the installation.

@kesepara
Copy link

@LukePenkava okay, i will try in the morning. thanks a lot.

@tarouboy
Copy link

Awesome! I am in similar situation and I thought I have to migrate to 0.60 ( which takes a long time ). Knowing that I can use 3.4.5 with 0.59.10 saved my life! <3

@tobiaseisenschenk
Copy link

unfortunately im on rn version 0.58.0, and installing any of the newer releases of this lib made my build fail. I decided to use release 3.0.2 (one before androidx support)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants