fix: Private office, classroom relative transforms

LayoutFunctions/LayoutFunctionCommon/LayoutStrategies.cs

@@ -273,8 +273,6 @@ public static void LimitWallCandidateOptionsByConfigId<TSpaceBoundary>(List<(Roo
             // If a set of wall candidate options are provided, limit to the one that aligns with the boundary's first edge.
             // In the future, as room shapes become more editable, we might want to pass in an explicit "orientation edge" instead of just using the first edge.
             var roomOrientationEdge = room.Boundary.Perimeter.Segments().First();
-            // // If we keep passing in already-transformed lines, we need to compare against the transformed first segment.
-            // var roomOrientationEdge = room.Boundary.Perimeter.Segments().First().TransformedLine(room.Transform);
             for (int i = wallCandidateOptions.Count - 1; i >= 0; i--)
             {
                 var (OrientationGuideEdge, _) = wallCandidateOptions[i];

LayoutFunctions/LayoutFunctionCommon/WallGeneration.cs

@@ -38,6 +38,8 @@ public static List<RoomEdge> FindWallCandidates(ISpaceBoundary room, Profile lev
             }), corridorSegments, levelProfile, out var wallCandidates);
             orientationGuideEdge.Type = room.DefaultWallType ?? "Glass";
             orientationGuideEdge.PrimaryEntryEdge = true;
+            // Return the orientation guide edge relative to the room's transform.
+            orientationGuideEdge.Line = orientationGuideEdge.Line.TransformedLine(room.Transform.Inverted());
             wallCandidateLines.Add(orientationGuideEdge);
             if (levelProfile != null)
             {
@@ -70,14 +72,16 @@ public static List<RoomEdge> FindWallCandidates(ISpaceBoundary room, Profile lev
             var thicknesses = room.Boundary.GetEdgeThickness();
             var allSegments = room.Boundary.Perimeter.Segments().Select((s, i) => new RoomEdge
             {
-                Line = new Line(s.Start, s.End),
+                Line = s.TransformedLine(room.Transform),
                 Thickness = thicknesses?.ElementAtOrDefault(i)
             }).ToList();
             var orientationGuideEdges = SortEdgesByPrimaryAccess(allSegments, corridorSegments, levelProfile, 0.3);
             foreach (var orientationGuideEdge in orientationGuideEdges)
             {
                 orientationGuideEdge.Line.Type = room.DefaultWallType ?? "Glass";
                 orientationGuideEdge.Line.PrimaryEntryEdge = true;
+                // Return the orientation guide edge relative to the room's transform.
+                orientationGuideEdge.Line.Line = orientationGuideEdge.Line.Line.TransformedLine(room.Transform.Inverted());
                 var wallCandidateLines = new List<RoomEdge>
                 {
                     orientationGuideEdge.Line
@@ -87,7 +91,7 @@ public static List<RoomEdge> FindWallCandidates(ISpaceBoundary room, Profile lev
                     var exteriorWalls = FindAllEdgesAdjacentToSegments(orientationGuideEdge.OtherSegments, levelProfile.Segments(), out var notAdjacentToFloorBoundary, out var corridorEdges);
                     wallCandidateLines.AddRange(notAdjacentToFloorBoundary.Select(s =>
                     {
-                        if (!orientationGuideEdges.Select(x => x.Line).Contains(s))
+                        if (!orientationGuideEdges.Select(x => x.Line.Line.TransformedLine(room.Transform)).Contains(s.Line))
                         {
                             s.Type = "Solid";
                         }
@@ -99,7 +103,7 @@ public static List<RoomEdge> FindWallCandidates(ISpaceBoundary room, Profile lev
                     // if no level or floor is present, everything that's not glass is solid.
                     wallCandidateLines.AddRange(orientationGuideEdge.OtherSegments.Select(s =>
                     {
-                        if (!orientationGuideEdges.Select(x => x.Line).Contains(s))
+                        if (!orientationGuideEdges.Select(x => x.Line.Line.TransformedLine(room.Transform)).Contains(s.Line))
                         {
                             s.Type = "Solid";
                         }

LayoutFunctions/PrivateOfficeLayout/src/PrivateOfficeLayout.cs

@@ -191,8 +191,7 @@ private static IEnumerable<SpaceBoundary> DivideBoundaryAlongVAxis(SpaceBoundary
                 }
                 var relativeRoomTransform = room.Transform.Concatenated(levelInvertedTransform);
                 var relativeRoomTransformProjected = new Transform(0, 0, -relativeRoomTransform.Origin.Z);
-                var orientationTransform = new Transform(Vector3.Origin, orientationGuideEdge.Direction, Vector3.ZAxis);
-                orientationTransform.Concatenate(relativeRoomTransform);
+                var orientationTransform = new Transform(Vector3.Origin, orientationGuideEdge.Direction, Vector3.ZAxis).Concatenated(relativeRoomTransform);
                 var boundaryCurves = new List<Polygon>();
                 boundaryCurves.Add(room.Boundary.Perimeter.TransformedPolygon(relativeRoomTransform));
                 boundaryCurves.AddRange(room.Boundary.Voids?.Select(v => v.TransformedPolygon(relativeRoomTransform)) ?? new List<Polygon>());