Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(util): update msrv to 1.61 #128

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Sep 6, 2024

Proposes to update http-body-util's MSRV to 1.61 to use rust-lang/rust#93827.

@tottoto tottoto force-pushed the update-util-msrv-to-1.61 branch from 5bc2ca1 to 99ecd6b Compare January 7, 2025 15:33
@seanmonstar seanmonstar merged commit fed1452 into hyperium:master Jan 7, 2025
8 checks passed
@tottoto tottoto deleted the update-util-msrv-to-1.61 branch January 8, 2025 03:03
@cratelyn cratelyn mentioned this pull request Jan 8, 2025
cratelyn added a commit to cratelyn/http-body that referenced this pull request Jan 15, 2025
this commit updates the MSRV of the `http-body` crate to 1.61.

this brings the `http-body` crate into step with the MSRV of the
`http-body-util` crate.

in hyperium#128, the MSRV of the `http-body-util` crate was update to 1.61.
however, compiling a crate in practice requires being able to parse all
of the package manifests in its workspace. this means that using more
recent features, like `dep:` syntax for optional dependencies included
via cargo features, will not work due to the older `1.49` toolchain
supported by `http-body`.

see the rust reference, here:
<https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies>

see hyperium#140, which depends on this commit.
seanmonstar pushed a commit that referenced this pull request Jan 15, 2025
this commit updates the MSRV of the `http-body` crate to 1.61.

this brings the `http-body` crate into step with the MSRV of the
`http-body-util` crate.

in #128, the MSRV of the `http-body-util` crate was update to 1.61.
however, compiling a crate in practice requires being able to parse all
of the package manifests in its workspace. this means that using more
recent features, like `dep:` syntax for optional dependencies included
via cargo features, will not work due to the older `1.49` toolchain
supported by `http-body`.

see the rust reference, here:
<https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies>

see #140, which depends on this commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants