Preserve invalid status code at best effort #336
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help on usecases mentioned in #144 without adding performance penalty for everyone else.
Theoretically with the original form, we can use
NonZeroU16
and Rust would optimizeResult<StatusCode, InvalidStatusCode>
to just au16
, which is probably unbeatable. But it isn't clear whether returningResult<u16, ()>
could really be faster thanResult<u16, u16>
.If that optimization does matter, we can probably hide the new field behind a feature and have people want it to opt in.