-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tower should be an optional dependency #79
Conversation
Sounds reasonable to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too, thanks!
Ah, looks like there's some |
Is this a breaking change? |
As |
The Line 30 in 99409f5
#[cfg(all(
any(feature = "http1", feature = "http2"),
any(feature = "server", feature = "client")
))]
pub use self::service::Service; |
As @tottoto said, this is not a break change. @davidpdrsn |
The
tower/tower-service
is only used in theclient/client-legacy
feature. If one only needsserver/server-auto
feature, there is no need to include them.Testing in sigoden/dufs#321, with this pr, there is a reduction of 0.3 M in the stripped release binary.