-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending HTTP/1.1 trailers #2719
Comments
seanmonstar
added
A-http1
Area: HTTP/1 specific.
E-medium
Effort: medium. Some knowledge of how hyper internal works would be useful.
C-feature
Category: feature. This is adding a new feature.
labels
Dec 10, 2021
@Xuanwo I've updated the issue above to include a list of things I think that needs to be done. If anything is missing, we can add more instructions here! |
hjr3
added a commit
to hjr3/hyper
that referenced
this issue
Oct 26, 2023
hjr3
added a commit
to hjr3/hyper
that referenced
this issue
Nov 4, 2023
hjr3
added a commit
to hjr3/hyper
that referenced
this issue
Nov 4, 2023
seanmonstar
pushed a commit
that referenced
this issue
Dec 15, 2023
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this issue
Jan 12, 2024
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this issue
Jan 16, 2024
…yperium#3375) Closes hyperium#2719 Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here's a list of pieces needed to make this work:
proto::h1::Dispatcher::poll_write()
so that when all data items are done (isNone
), check the body for trailspoll_trailers
.Wants::TRAILERS
, if we received a request withTE: trailers
. This could be useful to skip checking for trailers if the request never said it supports them.Pending
.proto::h1::Conn::write_trailers()
afterwrite_body()
. The dispatcher would call this.proto::h1::Encoder::encode_trailers()
that flattens theHeaderMap
into aBuf
.encode
file.tests/client.rs
andtests/server.rs
that both sides can send trailers.The text was updated successfully, but these errors were encountered: