Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to current rustc (closes #381) #382

Merged
merged 1 commit into from
Mar 20, 2015
Merged

Adapt to current rustc (closes #381) #382

merged 1 commit into from
Mar 20, 2015

Conversation

adrianheine
Copy link
Contributor

closes #381.

@GitCop
Copy link

GitCop commented Mar 19, 2015

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

  • Commit: 1b69c84
    • Commits must be in the following format: %{type}(%{scope}): %{description}
    • Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Mar 19, 2015

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

  • Commit: 72313b2
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@adrianheine
Copy link
Contributor Author

Travis is on 2015-03-14 and thus fails.

@Ryman
Copy link
Contributor

Ryman commented Mar 19, 2015

Shouldn't this be using http://doc.rust-lang.org/std/net/enum.SocketAddr.html?

@pyfisch
Copy link
Contributor

pyfisch commented Mar 19, 2015

@Ryman I also think it should be SocketAddr. Since we always use both host and port, we can replace the ip, port pair with a socket address.

@seanmonstar
Copy link
Member

It seems the removal of std::net::IpAddr was a mistake, and they're adding it back in...

@adrianheine
Copy link
Contributor Author

Using SocketAddr seems reasonable to me.

@seanmonstar seanmonstar merged commit 1f0bc95 into hyperium:master Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hyper doesn't built with new rustc.
5 participants