Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tower::Layer for tonic_web::Config #1117

Closed
slinkydeveloper opened this issue Oct 18, 2022 · 2 comments · Fixed by #1119
Closed

Implement tower::Layer for tonic_web::Config #1117

slinkydeveloper opened this issue Oct 18, 2022 · 2 comments · Fixed by #1119

Comments

@slinkydeveloper
Copy link
Contributor

Feature Request

Per title, tonic_web::Config is doing pretty much the job of a tower::Layer (see Config::enable function). Would it be possible to implement the tower::Layer interface directly?

Crates

  • tonic_web

Motivation

Better integration with tower based layers/services

Proposal

Implement tower::Layer for tonic_web::Config

Alternatives

Implement the layer manually now with a newtype
@LucioFranco
Copy link
Member

Yeah, this also seems like a fair ask. I would be interested in a PR for this to see how it looks.

slinkydeveloper added a commit to slinkydeveloper/tonic that referenced this issue Oct 19, 2022
@slinkydeveloper
Implement tower::Layer for tonic_web::Config. Fix hyperium#1117
60c0c54 
Signed-off-by: slinkydeveloper <[email protected]>
@slinkydeveloper slinkydeveloper mentioned this issue Oct 19, 2022
Merged
@slinkydeveloper
Copy link
Contributor Author

Here is the PR: #1119

slinkydeveloper added a commit to slinkydeveloper/tonic that referenced this issue Oct 24, 2022
@slinkydeveloper
Introduce GrpcWebLayer implementing tower::Layer. Fix hyperium#1117
fb2fe58 
Signed-off-by: slinkydeveloper <[email protected]>
slinkydeveloper added a commit to slinkydeveloper/tonic that referenced this issue Oct 24, 2022
@slinkydeveloper
Implement tower::Layer for tonic_web::Config. Fix hyperium#1117
32e87b3 
Signed-off-by: slinkydeveloper <[email protected]>
slinkydeveloper added a commit to slinkydeveloper/tonic that referenced this issue Oct 24, 2022
@slinkydeveloper
Introduce GrpcWebLayer implementing tower::Layer. Fix hyperium#1117
4b20717 
Signed-off-by: slinkydeveloper <[email protected]>
slinkydeveloper added a commit to slinkydeveloper/tonic that referenced this issue Oct 25, 2022
@slinkydeveloper
Introduce GrpcWebLayer implementing tower::Layer. Fix hyperium#1117
b326b39 
Signed-off-by: slinkydeveloper <[email protected]>
slinkydeveloper added a commit to slinkydeveloper/tonic that referenced this issue Oct 31, 2022
@slinkydeveloper
Implement tower::Layer for tonic_web::Config. Fix hyperium#1117
0b463d7 
Signed-off-by: slinkydeveloper <[email protected]>
slinkydeveloper added a commit to slinkydeveloper/tonic that referenced this issue Oct 31, 2022
@slinkydeveloper
Introduce GrpcWebLayer implementing tower::Layer. Fix hyperium#1117
18e6039 
Signed-off-by: slinkydeveloper <[email protected]>
slinkydeveloper added a commit to slinkydeveloper/tonic that referenced this issue Oct 31, 2022
@slinkydeveloper
Introduce GrpcWebLayer implementing tower::Layer. Fix hyperium#1117
14b93c0 
Signed-off-by: slinkydeveloper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement tower::Layer for tonic_web::Config slinkydeveloper/tonic
2 participants
@LucioFranco @slinkydeveloper