-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tonic-health: expose client #471
Comments
iirc tonic-health was just for the server side, but I am not opposed to exposing a client. I don't have much time right now to get to this but would love a PR :) cc @jen20 |
A PR you shall have 🎸 |
We could expose the |
I definitely planned to get to a client at some point! A PR would be great @LukeMathWalker! Personally I'd tend towards exposing a more idiomatic Rust API if possible, though the PB-generated code is not too bad in this case. |
It would be great to have the client generated for health checks. Kubernetes does not support grpc health checks natively and requires either a command line tool or a side container that acts as http/grpc proxy for health checks |
Yeah, I agree, we should expose the client and also the proto module (which would include the client). |
Co-authored-by: kvwu <[email protected]> Co-authored-by: Lucio Franco <[email protected]>
Feature Request
Crates
tonic-health
Motivation
Testing a server that exposes the health check service now requires:
Proposal
Add a new feature flag,
client
, totonic-health
to expose a gRPC client for the health check service.Would you prefer to expose the "raw" client as it comes out of
tonic-build
or would you prefer to wrap it in a nice Rust API that does not expose the underlying protobuf types?The text was updated successfully, but these errors were encountered: