-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): Reduce Default
bound requirement
#974
fix(build): Reduce Default
bound requirement
#974
Conversation
I think in something like this an overly expressive bound is good to help guide the compiler to better errors. Is there something that this is blocking for you? |
Yeah, as mentioned in the other issue, it blocks a lot of service layers that would otherwise be valid. I see your point however. There was a fix that I can make to box the responses or something on my end, but it seemed better to me if it wasn't necessary in the first place, as this is more churn for our company wide jump to tonic 0.7 If you don't want this, then I'd advise this limitation and ways to get around it be documented somewhere that's easy to find |
Oh I see now in #973 :) |
Default
bound in generated code to only where its needed
Outside of the one comment I had I think this looks good! |
Co-authored-by: David Pedersen <[email protected]>
Ok looks like we need to fix the one CI failure and then we can merge. I don't think this is a breaking change so we can get this out in a patch release. |
Default
bound in generated code to only where its neededDefault
bound requirement
Motivation
#973
It seems the
Default
bound was overly restrictiveSolution
Move the
Default
bound to thewith_interceptor
function instead of the whole impl