Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deflate compression support #2117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a1ien
Copy link

@a1ien a1ien commented Jan 3, 2025

Motivation

See #2116

Solution

Add support for deflate compression

@a1ien a1ien force-pushed the add_support_for_deflate branch from a8ddaf7 to 2c75a6a Compare January 3, 2025 15:50
@tottoto
Copy link
Collaborator

tottoto commented Jan 4, 2025

The deflate compression in gRPC means the zlib format with the deflate algorithm.

gRPC Compression - Deflate Compression

@a1ien
Copy link
Author

a1ien commented Jan 4, 2025

Oh.. Yeah true. I will replace DeflateEncoder/DeflateDecoder with ZlibEncoder/ZlibDecoder.
Are there any other objections/suggestions?

@tottoto
Copy link
Collaborator

tottoto commented Jan 4, 2025

The test located at tests/compression need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants