Use direction in error reporting during decode #374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not a bug-fix or a new feature as such. Just being more explicit and loud in reporting error using the communication direction.
Motivation
We encountered this error message today:
It's not immediately obvious as to whether this error-scenario was encountered while sending the request or while receiving the response. I think adding that information in the message would be highly helpful to figure out the actual source causing the error.
Solution
It's pretty simple. I used
self.direction
to detect the error-scenario (as in, sending or receiving?) and created an error message accordingly.Please let me know if this little improvement is acceptable in this form, or I missed out anything important. I'd like to make changes as required.