Skip to content

Commit

Permalink
Merge FYEO fixes (#988)
Browse files Browse the repository at this point in the history
* Make public initialize functions external (#953)

* Bump `solc` compiler versions to `0.8.16` (#952)

Co-authored-by: Asa Oines <[email protected]>
  • Loading branch information
yorhodes and asaj authored Aug 24, 2022
1 parent 33f43fc commit 4959f1e
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion solidity/app/hardhat.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = {
solidity: {
compilers: [
{
version: '0.8.13',
version: '0.8.16',
},
{
version: '0.7.6',
Expand Down
2 changes: 1 addition & 1 deletion solidity/core/contracts/Inbox.sol
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ contract Inbox is IInbox, ReentrancyGuardUpgradeable, Versioned, Mailbox {
// ============ Initializer ============

function initialize(uint32 _remoteDomain, address _validatorManager)
public
external
initializer
{
__ReentrancyGuard_init();
Expand Down
2 changes: 1 addition & 1 deletion solidity/core/contracts/Outbox.sol
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ contract Outbox is IOutbox, Versioned, MerkleTreeManager, Mailbox {

// ============ Initializer ============

function initialize(address _validatorManager) public initializer {
function initialize(address _validatorManager) external initializer {
__Mailbox_initialize(_validatorManager);
state = States.Active;
}
Expand Down
2 changes: 1 addition & 1 deletion solidity/core/hardhat.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import 'solidity-coverage';
*/
module.exports = {
solidity: {
version: '0.8.13',
version: '0.8.16',
settings: {
optimizer: {
enabled: true,
Expand Down
2 changes: 1 addition & 1 deletion typescript/helloworld/hardhat.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module.exports = {
solidity: {
compilers: [
{
version: '0.8.13',
version: '0.8.16',
},
],
},
Expand Down

0 comments on commit 4959f1e

Please sign in to comment.