address comments

hyperlane-xyz · Feb 20, 2025 · 730d5dd · 730d5dd
1 parent cc97546
commit 730d5dd
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 12 deletions.
diff --git a/typescript/infra/scripts/xerc20/xerc20vs-add-bridge.ts b/typescript/infra/scripts/xerc20/xerc20vs-add-bridge.ts
@@ -49,7 +49,12 @@ async function main() {
         envMultiProvider,
         dryRun,
       });
-    } catch {
+    } catch (e) {
+      rootLogger.error(
+        chalk.red(
+          `Error occurred while adding bridge to chain ${bridgeConfig.chain}: ${e}`,
+        ),
+      );
       erroredChains.push(bridgeConfig.chain);
     }
   }

diff --git a/typescript/infra/scripts/xerc20/xerc20vs-set-limits.ts b/typescript/infra/scripts/xerc20/xerc20vs-set-limits.ts
@@ -48,7 +48,10 @@ async function main() {
         envMultiProvider,
         dryRun,
       });
-    } catch {
+    } catch (e) {
+      rootLogger.error(
+        `Error occurred while setting limits for chain ${bridgeConfig.chain}: ${e}`,
+      );
       erroredChains.push(bridgeConfig.chain);
     }
   }

diff --git a/typescript/infra/src/xerc20/utils.ts b/typescript/infra/src/xerc20/utils.ts
@@ -63,7 +63,6 @@ export async function addBridgeToChain({
     bridgeAddress,
     bufferCap,
     rateLimitPerSecond,
-    owner: expectedOwner,
     decimals,
   } = bridgeConfig;
 
@@ -126,7 +125,6 @@ export async function addBridgeToChain({
       await sendTransactions(
         envMultiProvider,
         chain,
-        expectedOwner,
         [tx],
         xERC20Address,
         bridgeAddress,
@@ -161,7 +159,6 @@ export async function updateChainLimits({
 }) {
   const {
     bridgeAddress,
-    owner,
     bufferCap,
     rateLimitPerSecond,
     decimals,
@@ -209,7 +206,6 @@ export async function updateChainLimits({
     await sendTransactions(
       envMultiProvider,
       chain,
-      owner,
       txsToSend,
       xERC20Address,
       bridgeAddress,
@@ -290,21 +286,21 @@ async function checkOwnerIsSafe(
   proposer: Address,
   chain: string,
   multiProvider: MultiProvider,
-  safeAddress: Address,
+  owner: Address,
   bridgeAddress: Address,
 ): Promise<boolean> {
   // check if safe service is available
   await getSafeTxService(chain, multiProvider, bridgeAddress);
 
   try {
-    await getSafe(chain, multiProvider, safeAddress);
-    rootLogger.info(
-      chalk.gray(`[${chain}][${bridgeAddress}] Safe found: ${safeAddress}`),
+    await getSafe(chain, multiProvider, owner);
+    rootLogger.debug(
+      chalk.gray(`[${chain}][${bridgeAddress}] Safe found: ${owner}`),
     );
     return true;
   } catch {
     rootLogger.info(
-      chalk.gray(`[${chain}][${bridgeAddress}] Safe not found: ${safeAddress}`),
+      chalk.gray(`[${chain}][${bridgeAddress}] Safe not found: ${owner}`),
     );
     return false;
   }
@@ -446,7 +442,6 @@ function getTxCallData(transactions: PopulatedTransaction[]): CallData[] {
 async function sendTransactions(
   multiProvider: MultiProvider,
   chain: string,
-  expectedOwner: Address,
   transactions: PopulatedTransaction[],
   xERC20Address: Address,
   bridgeAddress: Address,