Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utils ParsedMessage type conflicts with calculator ParsedMessage type #1892

Closed
jmrossy opened this issue Mar 4, 2023 · 2 comments
Closed

Utils ParsedMessage type conflicts with calculator ParsedMessage type #1892

jmrossy opened this issue Mar 4, 2023 · 2 comments
Assignees
@jmrossy
Labels
bug Something isn't working sdk

Comments

@jmrossy
Copy link
Contributor

jmrossy commented Mar 4, 2023

https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/typescript/sdk/src/gas/calculator.ts#L67

https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/typescript/utils/src/types.ts#L43

There should be only 1 and it should probably be the utils verson
@jmrossy jmrossy added bug Something isn't working sdk labels Mar 4, 2023
@jmrossy jmrossy self-assigned this Mar 4, 2023
@jmrossy jmrossy moved this from Backlog to Sprint in Hyperlane Tasks Mar 4, 2023
@asaj
Copy link
Contributor

asaj commented Mar 20, 2023

FYI I'm deleting the calculator in #1907

@nambrot
Copy link
Contributor

nambrot commented Mar 23, 2023

Closing this unless anyone objects

@nambrot nambrot closed this as completed Mar 23, 2023
@github-project-automation github-project-automation bot moved this from Sprint to Done in Hyperlane Tasks Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmrossy jmrossy

Labels
bug Something isn't working sdk
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nambrot @jmrossy @asaj