Refactor IGP related code out of HyperlaneCore #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…monorepo into asaj/sdk-refactor
tkporter
added a commit
that referenced
this pull request
Mar 13, 2023
### Description * Adds DefaultIsmInterchainGasPaymaster to the checker and govern logic * I'm aware this conflicts with #1907 -- I wrote this mostly so I could propose new multisig txs to update the overhead gas amounts on mainnet. Happy to either merge this before or after #1907, whatever works easiest ### Drive-by changes * Some fixes in the wake of the sdk refactor, e.g.: * if some tx params like `maxPriorityFeePerGas` or `maxFeePerGas` were specified when we estimate gas, it can fail if the balance of the sender is insufficient. For cases where we want to estimate gas from the owner multisig which may not have native tokens, this caused issues. * We should've been passing the `from` address into the MultiProvider.estimateGas fn as a separate param ### Related issues n/a ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Ran & proposed some txs on mainnet to update the destination gas overheads
asaj
changed the title
This was referenced Mar 20, 2023
jmrossy
approved these changes
Mar 23, 2023
yorhodes
pushed a commit
that referenced
this pull request
Mar 23, 2023
change history!!! A number of changes intended to make the SDK more easily consumed by hyperlane-deploy - Splits the IGP related code out of HyperlaneCore* into HyperlaneIgp* - Moves agent config building from infra to SDK so that it can be accessed by hyperlane-deploy - Modifies CoreConfig to specify a ChainMap<MultisigIsmConfig> (i.e. specify everything that you need to know to deploy to a chain in that chain's CoreConfig) - Removes core.extendWithConnectionClientConfig - Moves common logic into HyperlaneAppGovernor to be shared between HyperlaneCoreGovernor and HyperlaneIgpGovernor - Adds TestRecipient contract addresses to the SDK addresses for consumption by hyperlane-deploy - Allow buildContracts to build when address keys are a superset of factory keys (via filterContracts). This is useful as it allows us to just throw all the addresses at a HyperlaneApp constructor without needing to remove the ones that aren't relevant - Removes InterchainGasCalculator, the logic we want to keep now lives in HyperlaneIgp - Allows chains to be added to a MultiProvider - Merges the infra govern script into the check script (to dedupe) - Some minor renaming where "Core" was being used liberally - Default to using whatever is configured in `owners.ts` in the router configs for infra (for ICA, IQS, HelloWorld, and LL deployment) - Fixes #[issue number here] _Are these changes backward compatible?_ No, existing consumers of the SDK may need to adjust. _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None _What kind of testing have these changes undergone?_ Manual / Unit Tests
Merged
Merged
yorhodes
added a commit
that referenced
this pull request
Mar 24, 2023
Changed in #1907 ### Testing Fork tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A number of changes intended to make the SDK more easily consumed by hyperlane-deploy
Drive-by changes
owners.tsin the router configs for infra (for ICA, IQS, HelloWorld, and LL deployment)Related issues
Backward compatibility
Are these changes backward compatible?
No, existing consumers of the SDK may need to adjust.
Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?
None
Testing
What kind of testing have these changes undergone?
Manual / Unit Tests