Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline config shapes (typescript) #2214

Closed
nambrot opened this issue May 10, 2023 · 2 comments · Fixed by #2491
Closed

Streamline config shapes (typescript) #2214

nambrot opened this issue May 10, 2023 · 2 comments · Fixed by #2491
Assignees
@jmrossy
Labels
dx sdk

Comments

@nambrot
Copy link
Contributor

nambrot commented May 10, 2023 •
edited
Loading

As a result from #1867, this ticket specifies the streamlining of our config shapes.

Specifically, explorer config becomes the merge of the existing ChainMetadata (with slightly modified keys) and HyperlaneDeploymentArtifacts from https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2203/files#diff-0dda34e51b45fcb259676791b216443495e465f6ec7c372fc77ec9abe9b8409aR90, and can be easily generated during a Hyperlane deploy and easily shared, and eventually able to be communicated to registries a la #2178 (instead of having to be manually constructed right now)

To do this, probably take the above draft PR, and make sure that it compiles in the sdk and adjust the consumers of ChainMetadata
@nambrot nambrot mentioned this issue May 10, 2023
Closed
@asaj
Copy link
Contributor

asaj commented May 10, 2023

@nambrot I think there are more contract addresses that would be good to share (e.g. ISM factories)

@nambrot
Copy link
Contributor Author

nambrot commented May 10, 2023

Ahh good, point, any other ones? Feel free to add them to the PR, otherwise I can

@nambrot nambrot mentioned this issue Jun 22, 2023
Closed
@nambrot nambrot moved this from Backlog to On-Deck in Hyperlane Tasks Jun 23, 2023
@nambrot nambrot moved this from On-Deck to Below Deck in Hyperlane Tasks Jun 23, 2023
@nambrot nambrot moved this from Below Deck to On-Deck in Hyperlane Tasks Jun 23, 2023
@nambrot nambrot moved this from On-Deck to Sprint in Hyperlane Tasks Jun 26, 2023
@nambrot nambrot mentioned this issue Jul 3, 2023
Merged
@jmrossy jmrossy mentioned this issue Jul 6, 2023
Merged
@nambrot nambrot moved this from Sprint to In Review in Hyperlane Tasks Jul 7, 2023
@nambrot nambrot moved this from In Review to In Progress in Hyperlane Tasks Jul 7, 2023
@nambrot nambrot moved this from In Progress to In Review in Hyperlane Tasks Jul 7, 2023
@jmrossy jmrossy moved this from In Review to In Progress in Hyperlane Tasks Jul 9, 2023
@jmrossy jmrossy mentioned this issue Jul 10, 2023
Closed
@jmrossy jmrossy moved this from In Progress to In Review in Hyperlane Tasks Jul 10, 2023
jmrossy added a commit that referenced this issue Jul 10, 2023
@jmrossy
Refactor ChainMetadata types (#2491)
395a069 
### Description
- Refactor ChainMetadata types into new folder
- Create metadata extensions for deployment artifacts, and agent config
- Remove explicit ChainMetadata interface and infer from zod schema instead

### Related issues

Implements new schema discussed in:
- #1867
- #2203
- #2214

Fixes #2214

### Backward compatibility

**No**: users of chain metadata configs would need to slightly modify their shape (the `rpcUrl` field)
@github-project-automation github-project-automation bot moved this from In Review to Done in Hyperlane Tasks Jul 10, 2023
@mattiekat mattiekat mentioned this issue Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmrossy jmrossy

Labels
dx sdk
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor ChainMetadata types hyperlane-xyz/hyperlane-monorepo
3 participants
@nambrot @jmrossy @asaj