-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native hooks in the mailbox #2381
Labels
Comments
aroralanuk
added a commit
that referenced
this issue
Jun 20, 2023
### Description - Adds support for the native Optimism bridge (L1->L2) to send messageID to be verified by the custom ISM on the rollup. - Only the smart contract component. - Outside Mailbox and needs to be called separately. - Uses Openzeppelin's CrossChainEnabled pattern for ensuring the right cross chain sender address. ### Drive-by changes - None ### Related issues - Fixes hyperlane-xyz/issues#379 - Opens #2409 - Related to #2381 ### Backward compatibility - Needs modifying the relayer to read OptimismISM's storage to wait for `receivedEmitters` mapping to get updated before retrying `process` on the mailbox. ### Testing - Unit Tests with Foundry forks and Optimism's L1-L2 messenger contracts. --------- Co-authored-by: Asa Oines <[email protected]>
One option would be to use L0's adapter params https://layerzero.gitbook.io/docs/evm-guides/advanced/relayer-adapter-parameters Another option would be to try to move anything that can't be deduced into the hook itself (i.e. make the hook very sender-specific) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hooks were conceived to support the use of other verification mechanisms to secure a Hyperlane message. E.g. in #2316, a message can be verified via the native L1-L2 Optimism bridge. However to support that, currently, the message sender has to explicitly do so via a hook contract on the origin chain (that the ISM on the destination chain permissions as the sender via the other verification mechanism).
When discussing the hooks, we thought of pulling the hooks into the Mailbox itself. That would allow message senders to not need to make contract bytecode change to support the change of an ISM on the destination. We started with the prototype outside since it would require no upgrade of the Mailbox.
In addition to supporting more ISMs on the desination for a message, there are other potential applications of native hooks in the mailbox:
Questions:
Tasks
The text was updated successfully, but these errors were encountered: