Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Support chain signer key as external secret #2543

Merged
merged 6 commits into from
Aug 23, 2023

Conversation

josedev-union
Copy link
Contributor

Description

This PR sets chain signer keys in the external secret.
related to #2458

Drive-by changes

Related issues

Backward compatibility

Testing

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8127fa5) 64.50% compared to head (d8f2dd3) 64.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2543   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files          91       91           
  Lines        1386     1386           
  Branches      185      185           
=======================================
  Hits          894      894           
  Misses        485      485           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josedev-union josedev-union force-pushed the support-chain-singer-key branch from b164464 to d09a841 Compare July 22, 2023 07:12
@josedev-union josedev-union force-pushed the support-chain-singer-key branch from d09a841 to cea4807 Compare July 22, 2023 07:16
@nambrot nambrot enabled auto-merge (squash) August 18, 2023 14:29
@nambrot nambrot merged commit 76467da into hyperlane-xyz:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants