Use mailbox callback to authenticate messages in hooks where necessary #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description - Adding default hook using custom config ### Drive-by changes - `postDispatch` is now public ### Related issues - v3 ### Backward compatibility Yes ### Testing None
This reverts commit 6832512.
yorhodes
changed the title
### Description - Added `FallbackDomainRoutingHook` which fallbacks to `mailbox.defaultHook` ### Drive-by changes - None ### Related issues - v3 - Needs to adapt to enumerable mapping after #2644 ### Backward compatibility Yes ### Testing - Unit testing
yorhodes
added a commit
that referenced
this pull request
Aug 18, 2023
#2609) Co-authored-by: Kunal Arora <[email protected]>
Closed
yorhodes
pushed a commit
that referenced
this pull request
Sep 13, 2023
Use mailbox callback to authenticate messages in hooks where necessary (#2609) Co-authored-by: Kunal Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
latestDispatchedIdtoMailboxfor use in hooks that need to authenticate message content (egOpStackHookorMerkleTreeHook). Removes concept ofnexthook from hook interface, which prescribed stack based approach.Drive-by changes
Inserts ISM used to verify messages into
DeliverycontextRelated issues
#2456 (comment)
Backward compatibility
Maintains backwards compatibility with
deliveredinterfaceTesting
WIP