Fix forge tests post V3 #2661
Merged
Fix forge tests post V3 #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorhodes
approved these changes
Aug 15, 2023
yorhodes
approved these changes
Aug 17, 2023
| @@ -144,7 +174,7 @@ contract ERC5164ISMTest is Test { | |||
| vm.startPrank(address(executor)); | |||
|
|
|||
| ism.verifyMessageId(messageId); | |||
| assertTrue(ism.verifiedMessages(messageId)); | |||
| assertTrue(ism.verifiedMessages(messageId).isBitSet(255)); | |||
There was a problem hiding this comment.
hmm
is there a simpler boolean interface for external consumption?
yorhodes
pushed a commit
that referenced
this pull request
Aug 18, 2023
- fixes GasRouter expectRevert message - added TestMerkleRootHook for proof() and fixes MerkleRootMultisig test - fixes ERC5164 tests post v3 changes - added contract name to mailbox and abstractHook error messages - removed unnecessary tests for "message too large" - downgrade slither in actions to 0.3.0 because of their recent "missing inheritance" bug on main - V3 Yes Unit tests
Closed
yorhodes
pushed a commit
that referenced
this pull request
Sep 13, 2023
- fixes GasRouter expectRevert message - added TestMerkleRootHook for proof() and fixes MerkleRootMultisig test - fixes ERC5164 tests post v3 changes - added contract name to mailbox and abstractHook error messages - removed unnecessary tests for "message too large" - downgrade slither in actions to 0.3.0 because of their recent "missing inheritance" bug on main - V3 Yes Unit tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
Backward compatibility
Yes
Testing
Unit tests