-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using Squads multisig with sealevel tooling, support ownership transfers in tooling #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… trevor/deploy-proteus
… trevor/deploy-proteus
… trevor/deploy-proteus
### Description In addition to the context, also configure the **chains** that an agent is deployable to. ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues - Fixes #2664 ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing Dry-ran the script for the three agents. Output for the validator looks wrong though: ``` % npx ts-node typescript/infra/scripts/agents/deploy-agents.ts -e mainnet2 -r validator --dry-run undefined ```
… trevor/deploy-proteus
…cus-monorepo into trevor/deploy-proteus
… trevor/deploy-proteus
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2700 +/- ##
=======================================
Coverage 64.50% 64.50%
=======================================
Files 91 91
Lines 1386 1386
Branches 185 185
=======================================
Hits 894 894
Misses 485 485
Partials 7 7 ☔ View full report in Codecov by Sentry. |
daniel-savu
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sadly, there's no programmatic way to submit transactions to Squads via an API or anything. As a workaround, if
-k
is passed a Pubkey and not a path to a Keypair as the payer, transactions will instead be logged in a base58 serialized format that can then be copied into Squads. Instructions for exactly how to do this are found in our NotionSo this includes:
Drive-by changes
rust/chains/hyperlane-sealevel/src/solana
that somehow got into main, I deleted thisRelated issues
part of https://github.com/hyperlane-xyz/issues/issues/545
Backward compatibility
backward compatible
Testing
Transferred ownership of devnet