Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using Squads multisig with sealevel tooling, support ownership transfers in tooling #2700

Merged
merged 41 commits into from
Sep 4, 2023

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented Sep 1, 2023

Description

Sadly, there's no programmatic way to submit transactions to Squads via an API or anything. As a workaround, if -k is passed a Pubkey and not a path to a Keypair as the payer, transactions will instead be logged in a base58 serialized format that can then be copied into Squads. Instructions for exactly how to do this are found in our Notion

So this includes:

  • Allow for the payer to just be a Pubkey without a Keypair
  • Some commands & functions to allow for ownership transfer

Drive-by changes

  • There was a whole directory rust/chains/hyperlane-sealevel/src/solana that somehow got into main, I deleted this
  • Cleaned up some logs to be formatted more nicely

Related issues

part of https://github.com/hyperlane-xyz/issues/issues/545

Backward compatibility

backward compatible

Testing

Transferred ownership of devnet

tkporter and others added 30 commits August 11, 2023 10:34
### Description

In addition to the context, also configure the **chains** that an agent
is deployable to.

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

- Fixes #2664

### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing
Dry-ran the script for the three agents. Output for the validator looks
wrong though:
```
% npx ts-node typescript/infra/scripts/agents/deploy-agents.ts -e mainnet2 -r validator --dry-run
undefined
```
@tkporter tkporter requested review from daniel-savu and removed request for asaj September 1, 2023 14:34
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (71e8988) 64.50% compared to head (97cca31) 64.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2700   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files          91       91           
  Lines        1386     1386           
  Branches      185      185           
=======================================
  Hits          894      894           
  Misses        485      485           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rust/sealevel/client/src/context.rs Outdated Show resolved Hide resolved
rust/sealevel/client/src/context.rs Outdated Show resolved Hide resolved
rust/sealevel/client/src/context.rs Outdated Show resolved Hide resolved
@tkporter tkporter enabled auto-merge (squash) September 4, 2023 15:09
@tkporter tkporter merged commit 2d8fced into main Sep 4, 2023
@tkporter tkporter deleted the trevor/squads branch September 4, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants