Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Ctrl+C while deploying #2710

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

aroralanuk
Copy link
Contributor

Description

  • Currently if you do keyboard interrupt while running the deploy script, none of the already deployed addresses get written to the artifacts.
  • Register a SIGINT handler in the deployWithArtifacts script

Drive-by changes

None

Related issues

None

Backward compatibility

Yes

Testing

Manual

@aroralanuk aroralanuk marked this pull request as ready for review September 6, 2023 18:43
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2b5d4c7) 64.50% compared to head (12d0a7a) 64.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2710   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files          91       91           
  Lines        1386     1386           
  Branches      185      185           
=======================================
  Hits          894      894           
  Misses        485      485           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@aroralanuk aroralanuk enabled auto-merge (squash) September 6, 2023 20:19
@aroralanuk aroralanuk merged commit 556efdb into main Sep 6, 2023
@aroralanuk aroralanuk deleted the handling-signint-deploy-with-artifacts branch September 6, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants