Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubbling up verification artifacts to verification.json #2817

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

aroralanuk
Copy link
Contributor

Description

  • Adding verification artifacts to the addDeployedContract function to add the verification inputs for the missing hooks.
  • Checking for duplicates while addign artifacts

Drive-by changes

None

Related issues

Backward compatibility

Yes

Testing

Manual

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2817 (7cda385) into v3 (b0870b1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #2817   +/-   ##
=======================================
  Coverage   61.76%   61.76%           
=======================================
  Files         100      100           
  Lines        1007     1007           
  Branches      104      104           
=======================================
  Hits          622      622           
  Misses        347      347           
  Partials       38       38           
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 67.93% <ø> (ø)
isms 67.91% <ø> (ø)
token 55.44% <ø> (ø)
middlewares 73.17% <ø> (ø)

@aroralanuk aroralanuk enabled auto-merge (squash) October 17, 2023 20:01
@yorhodes yorhodes disabled auto-merge October 19, 2023 14:09
@yorhodes yorhodes merged commit a330c71 into v3 Oct 19, 2023
@yorhodes yorhodes deleted the bubble-verification-artifacts branch October 19, 2023 14:09
@yorhodes yorhodes mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants