Remediate Trevor's comments #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aroralanuk
requested review from
tkporter,
nambrot,
yorhodes,
jmrossy,
daniel-savu,
Skunkchain and
avious00
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v3 #2835 +/- ##
==========================================
+ Coverage 62.07% 62.53% +0.46%
==========================================
Files 99 99
Lines 1002 1017 +15
Branches 104 106 +2
==========================================
+ Hits 622 636 +14
- Misses 343 344 +1
Partials 37 37
|
yorhodes
requested changes
Oct 23, 2023
solidity/contracts/isms/hook/AbstractMessageIdAuthorizedIsm.sol
Outdated
Show resolved
Hide resolved
solidity/contracts/isms/hook/AbstractMessageIdAuthorizedIsm.sol
Outdated
Show resolved
Hide resolved
solidity/contracts/isms/hook/AbstractMessageIdAuthorizedIsm.sol
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yorhodes
approved these changes
Oct 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing @tkporter 's comments from here: #2733
msg.valueexploit onAbstractMessageIdAuthorizedIsmDrive-by changes
none
Related issues
none
Backward compatibility
No
Testing
Unit