-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: e2e working with aggregation 2/2 of message_id
and merkle_root
#2861
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v3 #2861 +/- ##
=======================================
Coverage 66.96% 66.96%
=======================================
Files 99 99
Lines 1017 1017
Branches 106 106
=======================================
Hits 681 681
Misses 296 296
Partials 40 40
|
message_id
and merkle_root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what the unrelated changes are but probably @tkporter or @daniel-savu should approve first if you want to merge those
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lmk if you wanna chat about my suggestions - motivation is to remove all unwraps and to avoid the extra work just for logging purposes
…merkle-tree' into nambrot/repro-only-merkle-tree
Description
merkle_tree_builder.get_proof()
for fixing the following issue:Drive-by changes
sign_and_submit_checkpoint
Related issues
Backward compatibility
Yes
Testing
e2e