Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FS dep from sdk #2896

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Remove FS dep from sdk #2896

merged 1 commit into from
Nov 7, 2023

Conversation

yorhodes
Copy link
Member

@yorhodes yorhodes commented Nov 7, 2023

Description

Backward compatibility

Testing

None

@yorhodes yorhodes requested a review from jmrossy as a code owner November 7, 2023 19:01
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2896 (a5ab311) into v3 (4c49f61) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #2896   +/-   ##
=======================================
  Coverage   66.96%   66.96%           
=======================================
  Files          99       99           
  Lines        1017     1017           
  Branches      106      106           
=======================================
  Hits          681      681           
  Misses        296      296           
  Partials       40       40           
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 71.42% <ø> (ø)
isms 71.22% <ø> (ø)
token 58.41% <ø> (ø)
middlewares 81.46% <ø> (ø)

@yorhodes yorhodes enabled auto-merge (squash) November 7, 2023 19:14
@yorhodes yorhodes disabled auto-merge November 7, 2023 19:16
@yorhodes yorhodes merged commit 09550c3 into v3 Nov 7, 2023
@yorhodes yorhodes deleted the sdk-remove-fs branch November 7, 2023 19:16
@yorhodes yorhodes mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants